[WC-2826]: Export to excel types and formats #1941
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
spike/WC-2826-excel-types-format
branch
from
638b123 to
0945978
Compare
samuelreichert
force-pushed
the
spike/WC-2826-excel-types-format
branch
2 times, most recently
from
58c4f5e to
34fec3a
Compare
samuelreichert
force-pushed
the
spike/WC-2826-excel-types-format
branch
from
421eb46 to
0f5c3ba
Compare
r0b1n
reviewed
Nov 4, 2025
packages/pluggableWidgets/datagrid-web/src/features/data-export/DSExportRequest.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Nov 4, 2025
packages/pluggableWidgets/datagrid-web/src/features/data-export/DSExportRequest.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Nov 4, 2025
packages/pluggableWidgets/datagrid-web/src/features/data-export/DSExportRequest.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Nov 4, 2025
r0b1n
reviewed
Nov 6, 2025
Comment on lines
339
to
352
| function excelString(value: string): ExcelCell { | ||
| return { | ||
| t: "s", | ||
| v: value | ||
| }; | ||
| } | ||
|
|
||
| function excelStringFormat(value: string, format?: string): ExcelCell { | ||
| return { | ||
| t: "s", | ||
| v: value, | ||
| z: format | ||
| }; | ||
| } |
There was a problem hiding this comment.
It can be one method, I think
…sistency in cell formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Adding possibility to set type and format (masks) to export to excel in datagrid2.